GitHub user zhongneu opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/713
Add checkbox as a type of dynamic forms
First attempt to add checkbox support for dynamic forms. There are several
concerns:
1. I use Input.type to distinguish between "input", "selection" and
"checkbox" forms, but I am not sure whether Input.type has already been used by
any other places
2. Changed the way of detecting type of forms, which is not backward
compatible. This is probably not a problem, because the notebook will be
migrated into new version after the user run the paragraph
3. I think I need some guidance on the style sheet (I am a super new web
developer). Currently it is quite ugly
TODOs:
- [ ] Compatibility test with notes from previous versions
- [ ] Documentation for checkbox
- [ ] Nice CSS layout
Also fixed a bug in this pull request: ZEPPELIN-669
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhongneu/incubator-zeppelin
dynamic-forms-checkbox
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/713.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #713
----
commit 6969e8ca38ab5aa1370bee3cf792d8d639bdec2b
Author: Zhong Wang <[email protected]>
Date: 2016-02-13T04:52:37Z
first attempt of adding checkbox to dynamic forms
commit e190707c15629d25d00cdc1be5e757d2564a26d1
Author: Zhong Wang <[email protected]>
Date: 2016-02-13T06:09:38Z
fix several bugs, including ZEPPELIN-669
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
