Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/480#issuecomment-185301442
There is a few values or function, that seems out of place to me, for
example:
`$scope.paragraph.interpreterRestarting` should probably not be at
paragraph level, but at Notebook level since interpreters are linked to
Notebook. (and multiple paragraphs might share the same interpreter)
But since I don't have good solutions to re-organize the code better
(function and communication between controllers - wise), I think its fine.
However, for the `$scope.checkErrorForRestart()`, it is usually bad for
performances to link a function to a ng-show/hide or ng-if. Sometimes, it seems
inevitable, however in this case we could probably assign a value to this error
and change if when we process the query result.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
