GitHub user minahlee opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/770

    Change icon color when permission setting is open

    ### What is this PR for?
    * Set note action icon color to be changed properly
    * Switch location of _Settings_ and _Note permissions_
    
    ### What type of PR is it?
    Hot Fix
    
    ### What is the Jira issue?
    There is no jira issue
    
    ### Screenshots (if appropriate)
    
    **Before**
    ![screen shot 2016-03-09 at 3 07 43 
pm](https://cloud.githubusercontent.com/assets/8503346/13627348/1cb0f56c-e60d-11e5-94f0-95e824bb5c69.png)
    
    **After**
    ![screen shot 2016-03-09 at 3 06 44 
pm](https://cloud.githubusercontent.com/assets/8503346/13627350/1f0d427a-e60d-11e5-8e74-49c61854c523.png)
    
    **Before**
    ![screen shot 2016-03-09 at 3 07 56 
pm](https://cloud.githubusercontent.com/assets/8503346/13627359/31748658-e60d-11e5-8543-88bf676b2486.png)
    
    **After**
    ![screen shot 2016-03-09 at 3 07 02 
pm](https://cloud.githubusercontent.com/assets/8503346/13627363/362d0f94-e60d-11e5-93f0-5bf4fdc6297b.png)
    
    **Before(Permissions comes first)** 
    ![screen shot 2016-03-09 at 3 46 24 
pm](https://cloud.githubusercontent.com/assets/8503346/13627509/2eb84e62-e60e-11e5-812c-46ac88229782.png)
    
    **After(Settings comes first)** 
    ![screen shot 2016-03-09 at 3 46 33 
pm](https://cloud.githubusercontent.com/assets/8503346/13627506/2b53c45e-e60e-11e5-8dcb-9e27f3ec9ada.png)
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/minahlee/incubator-zeppelin 
fix/permissionActiveIconColor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/770.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #770
    
----
commit d1647131ff9b31e09f48e0c7bc2c1177cd01cbe4
Author: Mina Lee <mina...@nflabs.com>
Date:   2016-03-09T06:08:48Z

    Change icon color when permission setting is open
    Switch location of bind setting and permission

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to