GitHub user fireboy1919 opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/782

    Persist pool

    ### What is this PR for?
    This is a step towards creating a REST endpoint from resource pools  
https://issues.apache.org/jira/browse/ZEPPELIN-699
    
    It allows resources to be fully serializable so that the object that they 
contain can be passed around using thrift.
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [X] - Add serialization for rest endpoint
      [] - Create a REST endpoint
      [] - Create a pluggable API that accepts different kinds of resource 
pools.
      [] - Create a type of resource pool that persists.
    
    ### What is the Jira issue?
    Partially implements this:  
https://issues.apache.org/jira/browse/ZEPPELIN-699
    
    Note, that this pull request is dependent upon this one:  
    https://github.com/apache/incubator-zeppelin/pull/781
    
    Before that change is made, this will not compile.
    
    ### How should this be tested?
    There is a test class "org.apache.zeppelin.ResourceSerializerTest", but 
with no front-end, there isn't an easy manual way to test this.
    
    However, these steps will work:
    
    1. Start Zeppelin
    2. Run a paragraph.
    3.  Inspect 
"org.apache.zeppelin.resource.ResourcePoolUtils.getAllResources()".  You will 
see that this paragraph's results are included in this resource pool.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation?  No.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fireboy1919/incubator-zeppelin persist_pool

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/782.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #782
    
----
commit cbdb22d309948eaa2d7562c66c3b8780a6581647
Author: Rusty Phillips <ru...@cloudspace.com>
Date:   2016-03-15T23:11:20Z

    Added serialization to resourcepoolutils.

commit ffd092b6e7df495ecd1f4e753e3e88678bae2ead
Author: Rusty Phillips <ru...@cloudspace.com>
Date:   2016-03-15T23:06:35Z

    Added pool persistance.

commit 84cabe2d02a7cf49a82f56d8ae8cbbecb6699aaf
Author: Rusty Phillips <ru...@cloudspace.com>
Date:   2016-03-16T14:59:29Z

    Added test.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to