GitHub user Leemoonsoo opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/786

    [ZEPPELIN-755] Invalid notebook JSON file prevents Zeppelin daemon from 
starting

    ### What is this PR for?
    Invalid json file prevents Zeppelin daemon starting.
    This PR catches all exceptions during json file read. So Invalid notebook 
file will be skipped.
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [x] - Catch all exception and skip invalid json file reading
    * [x] - Unittest
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-755
    
    ### How should this be tested?
    Create any directory in notebook directory, and put empty note.json. And 
then start Zeppelin and see if daemon started.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/incubator-zeppelin ZEPPELIN-755

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/786.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #786
    
----
commit 9ced086e8bf596d15402ad8d3379452bac8635be
Author: Lee moon soo <m...@apache.org>
Date:   2016-03-20T00:43:27Z

    Catch all exceptions when listing

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to