Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-202170740
  
    @Leemoonsoo code looks good and rationale for customizing at least JVM 
properties now and leaving ui for env vars for further improvements makes 
sense. 
    
    If there are other PRs that handle this issue better - we can discuss 
alternative approaches and pick what's better implemented, otherwise 
@Leemoonsoo contribution looks good to merge for me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to