Github user rawkintrevo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/794#issuecomment-202599734
  
    After reviewing the other InterpreterTest files, I find that none utilize a 
test where the output '.contains' a specific string.  That specific test in 
Ignite is supposed to be testing for weather the interpreter is 'live' and can 
handle some basic commands which is verified by the assertion in the test.  
While it _should_ compile and regularly does. It seems to be consistently 
failing on one specific configuration, which leads me to believe the failure 
has more to do with the configuration than anything else.  
    
    Personally I would recommend dropping the line:
    `assertTrue(result.message().contains(sizeVal + ": Int = " + 
ignite.cluster().nodes().size()));`
    which is the line of failure in the Hadoop 1.6.0 builds, e.g. the hangup.  
The line preceding the proposed drop line asserts that the line is successfully 
executed.  E.g. `val " + sizeVal + " = ignite.cluster().nodes().size()` does 
successfully execute. The test that is causing failure is that what ever is 
returned by that line is not what one would expect. Again, ignite is the only 
interpreter to run this sort of test.  
    
    The ability to handle companion objects for all Ignite users seems more 
important than a possibly unexpected number of nodes reported in a very 
specific build of Hadoop. 
    
    Just my .02. 
    
    I have no problem resetting the Ignite files. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to