Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/761#issuecomment-208236629
@ankurmitujjain I did leave a comment before
> I think we would be better off using multiple PRs:
* #761 to replace the table only (if it brings better performances)
* #714 to have a download button available at all time for front data
* #725 to have a download button available at all time for back-end data
>The good thing would be that both back-end and front-end data download
would use the same UI, and it wouldn't add additional UI elements in the view
Furthermore, I found a few bugs with current implementation:
* We shouldn't be needing an additional scroll bar, nor floatHead
* The CSV buttons, appear after we switch to table only
* the search bar is unnecessary in non-table case
* It doesn't download the pivoted data (doesn't really matter)
* Hard to resize
Considering the plan for export, the next step would be to make this PR
adding datatable only:
* Remove download buttons
* Remove search input
* Make the datatable use its own scrollbar (and remove floathead)
* Make sure we can still resize the table
If you want, I can make a PR to your branch that take care of all these
points.
Then you can Fix the test (so we are sure you get the contributions during
the squash)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
