Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/816#issuecomment-210234523
  
    @fireboy1919 Thanks for the contribution.
    
    It looks like individual interpreter setting can configure ResourcePool 
implementation through it's property `ResourcePoolClass`. How about add some 
prefix on the property name, to distinguish from any other user defined 
properties? For example, like 
[zeppelin.interpreter.localRepo](https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java#L150),
 i think `zeppelin.interpreter.resourcePoolClass` make sense. 
    
    And how about add new configuration into 
[ZeppelinConfiguration](https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L440)
 to set default value of resourcePoolClass globally through 
conf/zeppelin-env.sh and conf/zeppelin-site.xml ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to