GitHub user rohannr opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/855

    ZEPPELIN-825: Set appropriate default permissions and allow user to c…

    ### What is this PR for?
    This PR makes users who set only r/w permissions the effective owners of 
the note.
    1. If you set readers, and writers and owners is empty, it is automatically 
set to the user requesting the change.
    2. If you set writers, and owners is empty, it is set it to the user 
requesting the change.
    It also fixes a bug that did not allow one to clear the permissions for a 
note. 
    
    ### What type of PR is it?
    Improvement 
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-818
    
    ### How should this be tested?
    * Create a new note
    * Set readers
    * Leave writers and owners empty and click Save.
    Expected: Writers and Owners is set to the user requesting the change. 
    
    
    …lear permissions
    
    This change makes users who set permissions the effective owners of the 
note.
    1. If you set readers, and writers and owners is empty, it is automatically 
set to the user requesting the change.
    2. If you set writers, and owners is empty, it is set it to the user 
requesting the change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rohannr/incubator-zeppelin ZEPPELIN-825

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/855.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #855
    
----
commit e29b9df42b3d74aef03edef40f681657f838c582
Author: Rohan Ramakrishna <roh...@twitter.com>
Date:   2016-04-21T22:36:17Z

    ZEPPELIN-825: Set appropriate default permissions and allow user to clear 
permissions
    
    This change makes users who set permissions the effective owners of the 
note.
    1. If you set readers, and writers and owners is empty, it is automatically 
set to the user requesting the change.
    2. If you set writers, and owners is empty, it is set it to the user 
requesting the change.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to