GitHub user wind0727 opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/861

    add note permission

    ### What is this PR for?
    resolve  logout so that people cannot access my notes, Notebook to modify 
the permissions will pop up, and provide the login button, rather than the 
login button on the home page
    
    ### What type of PR is it?
    [ Improvement ]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-723
    
    ### How should this be tested?
    1. create a notebook
    2. click Note Permission
    3. Enter comma separated users and groups,ex: owners:admin,user1; 
readers:*;writers:admin,user1
    4. click "Run this paragraph", warn "only admin,user1 can write this 
notebook ", prompt box show "Login" button
    5. click "Login" button, userName:user1,password:password2, after login 
success, click "Run this paragraph", can access this notebook
    6. click "Logout" button,cannot access this notebook
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wind0727/incubator-zeppelin branch_permission

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/861.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #861
    
----
commit d69dd1ddc431f016c17110da7687b6a781d51a09
Author: wind0727 <82651...@qq.com>
Date:   2016-04-28T02:47:27Z

    add note permission

commit 02e606d1a83558a7e9f480fcaa098059db368eb1
Author: wind0727 <82651...@qq.com>
Date:   2016-04-28T09:24:14Z

    add note permission

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to