opened an issue about the gitignore.. now looking into manually excluding it and/or updating apache's ignore config https://issues.apache.org/jira/browse/MNG-6594
On Tue, Feb 19, 2019 at 7:39 AM Adrian Cole <[email protected]> wrote: > > aye.. I removed it from git but yeah the thing bootstraps itself which I > guess the assembly is still picking up on... > > World would be easier if tools employed the .gitignore by default! > > On Mon, Feb 18, 2019, 10:36 PM Brian Devins-Suresh <[email protected] wrote: >> >> Unfortunately I have to vote -1 on this >> >> The maven-wrapper.jar file is still included in this release zip. >> >> > Running check: no binary files >> >> Executing `diff <(echo -n) <(find >> /var/folders/3s/y4tnvxcn27lgt1t75g3cl2bm0000gp/T/tmpj0wq4iyy/unzipped/brave-karaf-0.1.2 >> -type f | xargs file | grep -v text | cut -f1 -d:)` >> 0a1 >> > >> /var/folders/3s/y4tnvxcn27lgt1t75g3cl2bm0000gp/T/tmpj0wq4iyy/unzipped/brave-karaf-0.1.2/.mvn/wrapper/maven-wrapper.jar >> >> On Mon, Feb 18, 2019 at 12:34 AM Adrian Cole <[email protected]> >> wrote: >> >> > Hello Zipkin Community, >> > >> > This is a call for vote to release Apache Zipkin Brave Karaf >> > (incubating) version 0.1.2. >> > >> > The release candidates: >> > https://dist.apache.org/repos/dist/dev/incubator/zipkin/brave-karaf/0.1.2/ >> > >> > Git tag for the release: >> > https://github.com/apache/incubator-zipkin-brave-karaf/tree/v0.1.2 >> > >> > Hash for the release tag: >> > f930abb5c10d424ba1708b2e7a1fff42b972f165 >> > >> > Release Notes: >> > https://github.com/apache/incubator-zipkin-brave-karaf/releases/tag/v0.1.2 >> > >> > The artifacts have been signed with Key : BB67A050, which can be found >> > in the keys file: >> > https://dist.apache.org/repos/dist/dev/incubator/zipkin/KEYS >> > >> > Verification Hints: >> > For your convenience, the below includes detailed how-to on verifying >> > a source release. Please note that this document is a work-in-progress >> > >> > https://cwiki.apache.org/confluence/display/ZIPKIN/Verifying+a+Source+Release >> > >> > The vote will be open for at least 72 hours or until necessary number >> > of votes are reached. >> > >> > Please vote accordingly: >> > >> > [ ] +1 approve >> > [ ] +0 no opinion >> > [ ] -1 disapprove with the reason >> > >> > Thanks, >> > The Apache Zipkin (Incubating) Team >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [email protected] >> > For additional commands, e-mail: [email protected] >> > >> > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
