adriancole commented on a change in pull request #904: Messaging adapter URL: https://github.com/apache/incubator-zipkin-brave/pull/904#discussion_r282297593
########## File path: instrumentation/messaging/pom.xml ########## @@ -0,0 +1,51 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>io.zipkin.brave</groupId> + <artifactId>brave-instrumentation-parent</artifactId> + <version>5.6.4-SNAPSHOT</version> + </parent> + + <artifactId>brave-instrumentation-messaging</artifactId> + <name>Brave Instrumentation: Messaging</name> + + <properties> + <main.basedir>${project.basedir}/../..</main.basedir> + <main.java.version>1.8</main.java.version> Review comment: this won't work as JMS is java 6. please use java 6 for now as I don't think we need any Java 8 features in the types here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
