virendraagarwal edited a comment on issue #919: Span not reporting http status 
200 ok for successful api request
URL: 
https://github.com/apache/incubator-zipkin-brave/issues/919#issuecomment-498177975
 
 
   @adriancole we are at version 5.6.1 and i see code is same in both versions 
could you please point me changes in two files to me it looks like that only 
error code are mentioned in status 
   this is the comment in 5.6.3. Spring sleuth version 2.1.0 
   /** The intent of this is to by default add "http.status_code", when not a 
success code */

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to