adriancole commented on issue #920: brave.flush annotation reported for already finished span URL: https://github.com/apache/incubator-zipkin-brave/issues/920#issuecomment-501140805 PS the main concern is code calling `Tracer.currentSpan()` with no intention to use the span. I would recommend not doing that as it is useless overhead regardless of this issue. `Tracer.currentSpan()` implies bookkeeping etc. Can you mention the use case that led to all of this? Ex what is the scenario where a callback is calling `Tracer.currentSpan()` without using the result? If you are calling this just to check if a span is available, then another way, much cheaper in general way, is `CurrentTraceContext.get()`. Looking forward to more info. cheers!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
