adriancole commented on issue #924: Makes Tracer.currentSpanCustomizer() lazy URL: https://github.com/apache/incubator-zipkin-brave/pull/924#issuecomment-501230589 ps the use cases for calling tracer.currentSpan and not using the result are one of.. * checking null from `tracer.currentSpan()` as a signal for "is current" * defensively doing some parsing based on whether or not `Span.isNoop()` just guessing.. I think usually it would be a bug to call `Tracer.currentSpan()` and drop the result.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
