adriancole commented on issue #867: is there a plan to change alibaba-dubbo dependency to apache-dubbo? URL: https://github.com/apache/incubator-zipkin-brave/issues/867#issuecomment-501984781 sorry.. we had a lot of distractions over the last couple weeks. I tried what has been released and there are some compile concerns ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project brave-instrumentation-dubbo-rpc: Compilation failure: Compilation failure: [ERROR] /Users/acole/oss/incubator-zipkin-brave/instrumentation/dubbo-rpc/src/main/java/brave/dubbo/rpc/TracingFilter.java:[29,41] error: cannot find symbol [ERROR] symbol: class ExtensionLoader [ERROR] location: package com.alibaba.dubbo.common.extension [ERROR] /Users/acole/oss/incubator-zipkin-brave/instrumentation/dubbo-rpc/src/main/java/brave/dubbo/rpc/TracingFilter.java:[30,48] error: package com.alibaba.dubbo.config.spring.extension does not exist [ERROR] /Users/acole/oss/incubator-zipkin-brave/instrumentation/dubbo-rpc/src/main/java/brave/dubbo/rpc/TracingFilter.java:[31,42] error: cannot find symbol [ERROR] symbol: class ResponseCallback [ERROR] location: package com.alibaba.dubbo.remoting.exchange [ERROR] /Users/acole/oss/incubator-zipkin-brave/instrumentation/dubbo-rpc/src/main/java/brave/dubbo/rpc/TracingFilter.java:[38,43] error: package com.alibaba.dubbo.rpc.protocol.dubbo does not exist [ERROR] /Users/acole/oss/incubator-zipkin-brave/instrumentation/dubbo-rpc/src/main/java/brave/dubbo/rpc/TracingFilter.java:[154,51] error: cannot find symbol [ERROR] symbol: class ResponseCallback [ERROR] location: class TracingFilter [ERROR] /Users/acole/oss/incubator-zipkin-brave/instrumentation/dubbo-rpc/src/main/java/brave/dubbo/rpc/TracingFilter.java:[98,28] error: cannot find symbol [ERROR] symbol: class FutureAdapter [ERROR] location: class TracingFilter [ERROR] /Users/acole/oss/incubator-zipkin-brave/instrumentation/dubbo-rpc/src/main/java/brave/dubbo/rpc/TracingFilter.java:[100,10] error: cannot find symbol [ERROR] symbol: class FutureAdapter [ERROR] location: class TracingFilter [ERROR] /Users/acole/oss/incubator-zipkin-brave/instrumentation/dubbo-rpc/src/main/java/brave/dubbo/rpc/TracingFilter.java:[161,4] error: method does not override or implement a method from a supertype [ERROR] /Users/acole/oss/incubator-zipkin-brave/instrumentation/dubbo-rpc/src/main/java/brave/dubbo/rpc/TracingFilter.java:[165,4] error: method does not override or implement a method from a supertype [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <goals> -rf :brave-instrumentation-dubbo-rpc ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
