adriancole commented on a change in pull request #896: feat: use p6spy's log filtering settings when tracing URL: https://github.com/apache/incubator-zipkin-brave/pull/896#discussion_r294108847
########## File path: instrumentation/p6spy/README.md ########## @@ -42,3 +42,10 @@ jdbc:mysql://127.0.0.1:3306/mydatabase?zipkinServiceName=myServiceName This will override the `remoteServiceName` set in `spy.properties`. The current tracing component is used at runtime. Until you have instantiated `brave.Tracing`, no traces will appear. + +### Log filtering Review comment: ```suggestion ### Filtering spans ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
