[
https://issues.apache.org/jira/browse/ZOOKEEPER-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972814#action_12972814
]
Hadoop QA commented on ZOOKEEPER-500:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12466533/ZOOKEEPER-500.patch
against trunk revision 1049401.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/71//testReport/
Findbugs warnings:
https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/71//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/71//console
This message is automatically generated.
> Async methods shouldnt throw exceptions
> ---------------------------------------
>
> Key: ZOOKEEPER-500
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-500
> Project: ZooKeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Reporter: Utkarsh Srivastava
> Assignee: Flavio Junqueira
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-500.patch
>
>
> Async methods like asyncLedgerCreate and Open shouldnt be throwing
> InterruptedException and BKExceptions.
> The present method signatures lead to messy application code since one is
> forced to have error handling code in 2 places: inside the callback to
> handler a non-OK return code, and outside for handling the exceptions thrown
> by the call.
> There should be only one way to indicate error conditions, and that should be
> through a non-ok return code to the callback.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
