----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/234/ -----------------------------------------------------------
(Updated 2011-02-01 02:33:11.422161) Review request for zookeeper, Dhruba Borthakur and Benjamin Reed. Changes ------- Thanks for the comments, Ben. I have uploaded a new version of the patch. -F Summary ------- It is currently easy to know how many entries a ledger has, but there is no easy way to know the total number of bytes in a ledger. The idea of this jira is to add a method that gives the number of bytes in a closed ledger. My current idea is to simply have the writer counting the number of bytes written and store it to ZooKeeper. It is currently easy to know how many entries a ledger has, but there is no easy way to know the total number of bytes in a ledger. The idea of this jira is to add a method that gives the number of bytes in a closed ledger. My current idea is to simply have the writer counting the number of bytes written and store it to ZooKeeper. Diffs (updated) ----- trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/DigestManager.java 1055997 trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerEntry.java 1055997 trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerHandle.java 1055997 trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerMetadata.java 1055997 trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerRecoveryOp.java 1055997 trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/PendingReadOp.java 1055997 trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/tools/BookKeeperTools.java 1055997 trunk/src/contrib/bookkeeper/test/org/apache/bookkeeper/test/AsyncLedgerOpsTest.java 1055997 trunk/src/contrib/bookkeeper/test/org/apache/bookkeeper/test/BookieReadWriteTest.java 1055997 trunk/src/contrib/bookkeeper/test/org/apache/bookkeeper/test/LedgerRecoveryTest.java 1055997 Diff: https://reviews.apache.org/r/234/diff Testing ------- Thanks, fpj
