Thanks a lot Vishal. I have reviewed the patch already. Ill let ben decide how/when to commit to 3.3.3 branch. Ben let me know if you want me to commit the patch to 3.3 branch.
thanks mahadev On Wed, Feb 23, 2011 at 10:33 AM, Vishal Kher <vishalm...@gmail.com> wrote: > Hi Mahadev, > > I have submitted the patch to the jira. > > -Vishal > > On Tue, Feb 22, 2011 at 11:14 PM, Mahadev Konar <maha...@apache.org> wrote: > >> Thanks Ben. Vishal, would you be able to upload the patch today/tomm? >> I can review and commit. >> >> thanks >> mahadev >> >> On Tue, Feb 22, 2011 at 7:38 PM, Benjamin Reed <ben.r...@gmail.com> wrote: >> > sorry i didn't respond earlier. i've been off the grid today. (tahoe) >> since >> > i have to roll a new release anyway. i'd be glad to put it in. i just >> don't >> > want to delay the release any longer. >> > >> > ben >> > >> > On Tue, Feb 22, 2011 at 2:45 PM, Mahadev Konar <maha...@apache.org> >> wrote: >> > >> >> Hi Vishal, >> >> 900 seems like a biigger change. I think just 880 should be fine, so >> that >> >> folks dont hit the thread blow up issue. BTW, all depends on Ben if he >> is >> >> willing to get 880 in 3.3.3 release. If not we'll have to wait for 3.4 >> or >> >> another release like 3.3.4 (which i personally would like to avoid). >> >> >> >> thanks >> >> mahadev >> >> >> >> On Tue, Feb 22, 2011 at 1:09 PM, Vishal Kher <vishalm...@gmail.com> >> wrote: >> >> >> >>> Hi Mahadev, >> >>> >> >>> I can certainly work on getting 880 in the release. I would like to >> know >> >>> if 900 needs to go in 3.3.3 or not. If I remember correctly, merging >> patch >> >>> for 880 failed when I tired last time because the fix for 900 was not >> >>> committed to 3.3.If 900 is not needed, then I can do the fix only for >> 880. >> >>> Shouldn't take that long. Note - without the fix for 900, QCM can block >> >>> indefinitely. This can cause serious problems during leader election >> >>> (especially in a 3 node setup). Let me know. >> >>> >> >>> -Vishal >> >>> >> >>> btw, will there be another release before 3.4.0? We would like to have >> >>> patches to ZOOKEEPER-932< >> https://issues.apache.org/jira/browse/ZOOKEEPER-932>and >> >>> ZOOKEEPER-975 >> >>> <https://issues.apache.org/jira/browse/ZOOKEEPER-975>released >> soon as well. >> >>> >> >>> >> >>> On Tue, Feb 22, 2011 at 1:53 PM, Mahadev Konar <maha...@apache.org >> >wrote: >> >>> >> >>>> Ben/Vishal, >> >>>> Is there any possibility of getting ZOOKEEPER-880 in 3.3.3 release? >> The >> >>>> Hbase guys had been asking for it. >> >>>> >> >>>> thanks >> >>>> mahadev >> >>>> >> >>>> >> >>>> On Tue, Feb 22, 2011 at 9:38 AM, Flavio Junqueira <f...@yahoo-inc.com >> >wrote: >> >>>> >> >>>>> I'm not sure why you say it is fine, Pat. If I try to compile with >> the >> >>>>> candidate release, ant complains that build-contrib.xml is missing >> (and it >> >>>>> is not where it is supposed to be). Compiling from trunk or one of >> the >> >>>>> branches works fine, though. >> >>>>> >> >>>>> -Flavio >> >>>>> >> >>>>> On Feb 22, 2011, at 6:04 PM, Patrick Hunt wrote: >> >>>>> >> >>>>> I think it's fine - it's in src/contrib not contrib. >> >>>>> >> >>>>> On Tue, Feb 22, 2011 at 8:00 AM, Benjamin Reed <ben.r...@gmail.com> >> >>>>> wrote: >> >>>>> >> >>>>> i don't know why build-contrib.xml is missing. pat do you have any >> >>>>> ideas? >> >>>>> >> >>>>> ant tar should grab it right? >> >>>>> >> >>>>> >> >>>>> ben >> >>>>> >> >>>>> >> >>>>> >> >>>>> On Mon, Feb 21, 2011 at 2:02 AM, Flavio Junqueira <f...@yahoo-inc.com >> >>>>> >wrote: >> >>>>> >> >>>>> >> >>>>> Ben, I have a question. Even though the bookkeeper jar is there, >> >>>>> >> >>>>> build-contrib.xml is missing (ZOOKEEPER-956), and compiling fails >> >>>>> without >> >>>>> >> >>>>> it. Is it supposed to be this way? >> >>>>> >> >>>>> >> >>>>> -Flavio >> >>>>> >> >>>>> >> >>>>> >> >>>>> On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote: >> >>>>> >> >>>>> >> >>>>> (the previous email had the URL slightly incorrect) >> >>>>> >> >>>>> >> >>>>> after much struggle! i've created a candidate build for ZooKeeper >> 3.3.3. >> >>>>> >> >>>>> this is a bug fix >> >>>>> >> >>>>> release addressing 13 issues (two of them extremely critical) -- see >> the >> >>>>> >> >>>>> release notes for details. >> >>>>> >> >>>>> >> >>>>> *** Please download, test and VOTE before the >> >>>>> >> >>>>> *** vote closes 11pm pacific time, Tuesday, February 22.*** >> >>>>> >> >>>>> >> >>>>> http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/ >> >>>>> >> >>>>> >> >>>>> one thing that has not been fixed in this release is that the docs >> still >> >>>>> >> >>>>> reference hadoop. this will be fixed in a future release. >> >>>>> >> >>>>> >> >>>>> should we release this? >> >>>>> >> >>>>> >> >>>>> ben >> >>>>> >> >>>>> >> >>>>> ps - give that this is the first release there is more than likely >> >>>>> >> >>>>> something >> >>>>> >> >>>>> i missed and given the severity of issues addressed it would be nice >> to >> >>>>> >> >>>>> get >> >>>>> >> >>>>> it out quickly. please review ASAP. >> >>>>> >> >>>>> >> >>>>> >> >>>>> *flavio* >> >>>>> >> >>>>> *junqueira* >> >>>>> >> >>>>> >> >>>>> research scientist >> >>>>> >> >>>>> >> >>>>> f...@yahoo-inc.com >> >>>>> >> >>>>> direct +34 93-183-8828 >> >>>>> >> >>>>> >> >>>>> avinguda diagonal 177, 8th floor, barcelona, 08018, es >> >>>>> >> >>>>> phone (408) 349 3300 fax (408) 349 3301 >> >>>>> >> >>>>> >> >>>>> >> >>>>> >> >>>>> >> >>>>> >> >>>>> *flavio* >> >>>>> *junqueira* >> >>>>> >> >>>>> research scientist >> >>>>> >> >>>>> f...@yahoo-inc.com >> >>>>> direct +34 93-183-8828 >> >>>>> >> >>>>> avinguda diagonal 177, 8th floor, barcelona, 08018, es >> >>>>> phone (408) 349 3300 fax (408) 349 3301 >> >>>>> >> >>>>> >> >>>>> >> >>>> >> >>> >> >> >> > >> >
