[ https://issues.apache.org/jira/browse/ZOOKEEPER-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002748#comment-13002748 ]
Hadoop QA commented on ZOOKEEPER-837: ------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12472355/ZOOKEEPER-837.patch against trunk revision 1074995. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/176//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/176//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/176//console This message is automatically generated. > cyclic dependency ClientCnxn, ZooKeeper > --------------------------------------- > > Key: ZOOKEEPER-837 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-837 > Project: ZooKeeper > Issue Type: Sub-task > Affects Versions: 3.3.1 > Reporter: Patrick Datko > Assignee: Thomas Koch > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-837.patch, ZOOKEEPER-837.patch, > ZOOKEEPER-837.patch, ZOOKEEPER-837.patch > > > ZooKeeper instantiates ClientCnxn in its ctor with this and therefor builds a > cyclic dependency graph between both objects. This means, you can't have the > one without the other. So why did you bother do make them to separate classes > in the first place? > ClientCnxn accesses ZooKeeper.state. State should rather be a property of > ClientCnxn. And ClientCnxn accesses zooKeeper.get???Watches() in its method > primeConnection(). I've not yet checked, how this dependency should be > resolved better. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira