DateFormat.getDateTimeInstance() is very expensive, we can cache it to improve performance ------------------------------------------------------------------------------------------
Key: ZOOKEEPER-1015 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1015 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.3.2 Reporter: Xiaoming Shi In the file {noformat} ./zookeeper-3.3.2/src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java line:103 {noformat} DateFormat.getDateTimeInstance() is called many times in the for loop. We can cache the result and improve the performance This is similar to the Apache bug https://issues.apache.org/bugzilla/show_bug.cgi?id=48778 Similar code can be found: {noformat} ./zookeeper-3.3.2/src/java/main/org/apache/zookeeper/server/TraceFormatter.java ./zookeeper-3.3.2/src/java/main/org/apache/zookeeper/server/LogFormatter.java {noformat} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira