[ https://issues.apache.org/jira/browse/ZOOKEEPER-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009358#comment-13009358 ]
Michi Mutsuzaki commented on ZOOKEEPER-850: ------------------------------------------- +1. There is one findbugs warning, but it's not this patch that introduced it. === Exception is caught when Exception is not thrown in org.apache.zookeeper.server.quorum.QuorumPeer$ResponderThread.run() Bug type REC_CATCH_EXCEPTION (click for details) In class org.apache.zookeeper.server.quorum.QuorumPeer$ResponderThread In method org.apache.zookeeper.server.quorum.QuorumPeer$ResponderThread.run() At QuorumPeer.java:[line 310] > Switch from log4j to slf4j > -------------------------- > > Key: ZOOKEEPER-850 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-850 > Project: ZooKeeper > Issue Type: Improvement > Components: java client > Affects Versions: 3.3.1 > Reporter: Olaf Krische > Assignee: Olaf Krische > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-3.3.1-log4j-slf4j-20101031.patch.bz2, > ZOOKEEPER-3.4.0-log4j-slf4j-20101102.patch.bz2, ZOOKEEPER-850.patch, > ZOOKEEPER-850.patch, ZOOKEEPER-850.patch, ZOOKEEPER-850.patch > > > Hello, > i would like to see slf4j integrated into the zookeeper instead of relying > explicitly on log4j. > slf4j is an abstract logging framework. There are adapters from slf4j to many > logger implementations, one of them is log4j. > The decision which log engine to use i dont like to make so early. > This would help me to embed zookeeper in my own applications (which use a > different logger implemenation, but slf4j is the basis) > What do you think? > (as i can see, those slf4j request flood all other projects on apache as well > :-) > Maybe for 3.4 or 4.0? > I can offer a patchset, i have experience in such an migration already. :-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira