[ https://issues.apache.org/jira/browse/ZOOKEEPER-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037028#comment-13037028 ]
Hadoop QA commented on ZOOKEEPER-1063: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479523/ZOOKEEPER-1063.patch against trunk revision 1125179. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/278//console This message is automatically generated. > Dubious synchronization in Zookeeper and ClientCnxnSocketNIO classes > -------------------------------------------------------------------- > > Key: ZOOKEEPER-1063 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1063 > Project: ZooKeeper > Issue Type: Bug > Components: java client > Reporter: Yanick Dufresne > Assignee: Yanick Dufresne > Priority: Critical > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-1063.patch > > > Synchronization around dataWatches, existWatches and childWatches in > Zookeeper is incorrect. > Synchronization around outgoingQueue and pendingQueue in ClientCnxnSocketNIO > is incorrect. > Synchronization around selector and key sets in ClientCnxnSocketNIO seems odd. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira