[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051296#comment-13051296 ]
Hadoop QA commented on ZOOKEEPER-1087: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12482979/ZOOKEEPER-1087.patch against trunk revision 1136740. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/327//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/327//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/327//console This message is automatically generated. > ForceSync VM arguement not working when set to "no" > --------------------------------------------------- > > Key: ZOOKEEPER-1087 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.3.2, 3.3.3 > Reporter: Ankit Patel > Assignee: Nate Putnam > Priority: Blocker > Fix For: 3.3.4, 3.4.0 > > Attachments: ZOOKEEPER-1087.patch > > Original Estimate: 5m > Remaining Estimate: 5m > > Cannot use forceSync=no to asynchronously write transaction logs. This is a > critical bug, please address it ASAP. More details: > The class org.apache.zookeeper.server.persistence.FileTxnLog initializes > forceSync property in a static block. However, the static variable is defined > after the static block with a default value of true. Therefore, the value of > the variable can never be false. Please move the declaration of the variable > before the static block. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira