[
https://issues.apache.org/jira/browse/ZOOKEEPER-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068537#comment-13068537
]
Eugene Koontz commented on ZOOKEEPER-1104:
------------------------------------------
sorry should have read "since June 21-June 22"
{{
commit 9619bd31d5b191fdb7d622d2bb84fac92ab1111c
Author: Patrick D. Hunt <[email protected]>
Date: Wed Jun 22 19:35:55 2011 +0000
Fixed a problem introduced by the first patch for ZOOKEEPER-1103 (phunt)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1138595
13f79535-47bb-0310-9956-ffa450edef68
commit 77992edd8abc6ffd759d60266e55fd3b388b7d3a
Author: Patrick D. Hunt <[email protected]>
Date: Tue Jun 21 22:19:04 2011 +0000
ZOOKEEPER-1103. In QuorumTest, use the same "for ( .. try { break } catch {
} )" pattern in testFollowersStartAfterLeaders as in testSessionMove. (Eugene
Koontz v
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1138213
13f79535-47bb-0310-9956-ffa450edef68
}}
> CLONE - In QuorumTest, use the same "for ( .. try { break } catch { } )"
> pattern in testFollowersStartAfterLeaders as in testSessionMove.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1104
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1104
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.3, 3.4.0
> Reporter: sreekanth
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_branch_3_3.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking
> for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach
> that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
