[
https://issues.apache.org/jira/browse/ZOOKEEPER-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087255#comment-13087255
]
Hadoop QA commented on ZOOKEEPER-1156:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12490846/ZOOKEEPER-1156.patch
against trunk revision 1157698.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/465//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/465//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/465//console
This message is automatically generated.
> Log truncation truncating log too much - can cause data loss
> ------------------------------------------------------------
>
> Key: ZOOKEEPER-1156
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1156
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum, server
> Affects Versions: 3.3.3
> Reporter: Vishal Kathuria
> Priority: Blocker
> Fix For: 3.3.4
>
> Attachments: ZOOKEEPER-1156.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The log truncation relies on position calculation for a particular zxid to
> figure out the new size of the log file. There is a bug in
> PositionInputStream implementation which skips counting the bytes in the log
> which have value 0. This can lead to underestimating the actual log size. The
> log records which should be there can get truncated, leading to data loss on
> the participant which is executing the trunc.
> Clients can see different values depending on whether they connect to the
> node on which trunc was executed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
