----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1880/#review1897 -----------------------------------------------------------
lgtm. I'm personally in favor of moving to guava if that floats your boat (future patches). It came up briefly during the postsummit meetup and ppl seemed generally in favor. btw: please mention the JIRA # in the summary. e.g. "ZOOKEEPER-1234 <jira summary text>" src/java/test/org/apache/zookeeper/test/CnxManagerTest.java <https://reviews.apache.org/r/1880/#comment4380> 1L ? src/java/test/org/apache/zookeeper/test/CnxManagerTest.java <https://reviews.apache.org/r/1880/#comment4381> 2L ? - Patrick On 2011-09-14 11:07:49, Thomas Koch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1880/ > ----------------------------------------------------------- > > (Updated 2011-09-14 11:07:49) > > > Review request for zookeeper. > > > Summary > ------- > > . > > > This addresses bug ZOOKEEPER-1182. > https://issues.apache.org/jira/browse/ZOOKEEPER-1182 > > > Diffs > ----- > > src/java/test/org/apache/zookeeper/JUnit4ZKTestRunner.java 188c9f7 > src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 7419510 > src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java > 45a61c7 > src/java/test/org/apache/zookeeper/test/ChrootTest.java 3df068b > src/java/test/org/apache/zookeeper/test/ClientBase.java 0fc7d25 > src/java/test/org/apache/zookeeper/test/ClientHammerTest.java 581402c > src/java/test/org/apache/zookeeper/test/CnxManagerTest.java fed68c1 > src/java/test/org/apache/zookeeper/test/FLELostMessageTest.java 98f8e10 > src/java/test/org/apache/zookeeper/test/FLERestartTest.java f092563 > src/java/test/org/apache/zookeeper/test/FLETest.java f1e050d > src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java f3d1316 > src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java 3658714 > src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java d92f2d3 > src/java/test/org/apache/zookeeper/test/MaxCnxnsTest.java 38e84fa > src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java fa9c8f3 > src/java/test/org/apache/zookeeper/test/QuorumTest.java 13d0e83 > src/java/test/org/apache/zookeeper/test/QuorumUtil.java a68ebec > src/java/test/org/apache/zookeeper/test/SledgeHammer.java 614a93d > src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java fa0128c > src/java/test/org/apache/zookeeper/test/UpgradeTest.java b8db0da > src/java/test/org/apache/zookeeper/test/WatchedEventTest.java 0eaea67 > src/java/test/org/apache/zookeeper/test/WatcherTest.java 90ec513 > src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java 67ca52f > > Diff: https://reviews.apache.org/r/1880/diff > > > Testing > ------- > > > Thanks, > > Thomas > >
