[
https://issues.apache.org/jira/browse/ZOOKEEPER-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104945#comment-13104945
]
[email protected] commented on ZOOKEEPER-96:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1711/
-----------------------------------------------------------
(Updated 2011-09-14 22:18:33.262563)
Review request for zookeeper.
Summary (updated)
-------
The patch seems large since it removes the generated java files. Actually there
are only small changes in build.xml and ivy.xml
Motivation for this patch: I want to get the warnings in eclipse down to make
them useful again. Some of the warnings are in the generated jj files. I'll
fill another issue+patch that solves more warnings in the rcc.jj definition.
This addresses bug ZOOKEEPER-96.
https://issues.apache.org/jira/browse/ZOOKEEPER-96
Diffs
-----
src/java/main/org/apache/jute/compiler/generated/RccTokenManager.java 5ae99e2
src/java/main/org/apache/jute/compiler/generated/RccConstants.java 9640efb
build.xml 7248c34
ivy.xml ea7460d
src/java/main/org/apache/jute/compiler/generated/ParseException.java e4b0a9b
src/java/main/org/apache/jute/compiler/generated/Rcc.java 1bd4878
src/java/main/org/apache/jute/compiler/generated/SimpleCharStream.java
e38b451
src/java/main/org/apache/jute/compiler/generated/Token.java 3e7018b
src/java/main/org/apache/jute/compiler/generated/TokenMgrError.java e246962
Diff: https://reviews.apache.org/r/1711/diff
Testing
-------
yes
Thanks,
Thomas
> The jute parser should get generated from the jj files instead of checking in
> the generated sources
> ---------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-96
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-96
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Reporter: Hiram Chirino
> Assignee: Thomas Koch
> Attachments: ZOOKEEPER-96.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
