[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104994#comment-13104994
 ] 

Hadoop QA commented on ZOOKEEPER-1182:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12494515/ZOOKEEPER-1182.patch
  against trunk revision 1170886.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 69 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/541//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/541//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/541//console

This message is automatically generated.

> Make findbugs usable in Eclipse
> -------------------------------
>
>                 Key: ZOOKEEPER-1182
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1182
>             Project: ZooKeeper
>          Issue Type: Task
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1182.patch, ZOOKEEPER-1182.patch
>
>
> I did not find any way how one could tell the eclipse findbugs extension to 
> ignore the java files under src/java/test. I already use 
> src/java/test/config/findbugsExcludeFile.xml but there are still many findbug 
> warnings.
> So this patch solves the most obvious findbugs warnings under src/java/test. 
> There are 30 remaining warnings which could either be ignored in the exclude 
> file or solved by somebody with more knowledge about the code.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to