[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105505#comment-13105505
 ] 

Hadoop QA commented on ZOOKEEPER-556:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12494612/ZOOKEEPER-556.patch
  against trunk revision 1170886.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 5 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/553//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/553//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/553//console

This message is automatically generated.

> Startup messages should account for common error of missing leading slash in 
> config files
> -----------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-556
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-556
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Ted Dunning
>            Assignee: Thomas Koch
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-556.patch, ZOOKEEPER-556.patch, 
> ZOOKEEPER-556.patch, ZOOKEEPER-556.patch
>
>
> It would be nice if the startup noticed directories without a leading slash 
> in the config file.  That is worth a warning.
> Moreover, if that directory exists looking from root, but not looking from 
> the current directory, a very serious warning is in order.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to