[
https://issues.apache.org/jira/browse/ZOOKEEPER-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118482#comment-13118482
]
Hadoop QA commented on ZOOKEEPER-1174:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12497223/ZOOKEEPER-1174-3.3.patch
against trunk revision 1177432.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/600//console
This message is automatically generated.
> FD leak when network unreachable
> --------------------------------
>
> Key: ZOOKEEPER-1174
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1174
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
> Affects Versions: 3.3.3
> Reporter: Ted Dunning
> Assignee: Ted Dunning
> Priority: Critical
> Fix For: 3.3.4, 3.4.0, 3.5.0
>
> Attachments: ZOOKEEPER-1174-3.3.patch, ZOOKEEPER-1174.patch,
> ZOOKEEPER-1174.patch, ZOOKEEPER-1174.patch, ZOOKEEPER-1174.patch,
> ZOOKEEPER-1174.patch, ZOOKEEPER-1174fix.patch, zk-fd-leak.tgz
>
>
> In the socket connection logic there are several errors that result in bad
> behavior. The basic problem is that a socket is registered with a selector
> unconditionally when there are nuances that should be dealt with. First, the
> socket may connect immediately. Secondly, the connect may throw an
> exception. In either of these two cases, I don't think that the socket
> should be registered.
> I will attach a test case that demonstrates the problem. I have been unable
> to create a unit test that exhibits the problem because I would have to mock
> the low level socket libraries to do so. It would still be good to do so if
> somebody can figure out a good way.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
