[
https://issues.apache.org/jira/browse/ZOOKEEPER-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127726#comment-13127726
]
Hadoop QA commented on ZOOKEEPER-1227:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12499067/ZOOKEEPER-1227.patch
against trunk revision 1180217.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/620//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/620//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/620//console
This message is automatically generated.
> Zookeeper logs is showing -1 as min/max session timeout if there is no
> sessiontimeout value configured
> ------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1227
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1227
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.3
> Reporter: Rakesh R
> Assignee: Rakesh R
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1227.patch
>
>
> When starting the ZooKeeper without configuring 'minimumSessionTimeOut' and
> 'maximumSessionTimeOut'.
> I'm seeing the '-1' as the lower and the upper bound, instead it should give
> the default values : tickTime*2 and tickTime*20
> {noformat}
> 2011-10-14 13:07:18,761 - INFO [main:QuorumPeerConfig@92] - Reading
> configuration from:
> /home/amith/CI/source/install/zookeeper/zookeeper1/bin/../conf/zoo.cfg
> 2011-10-14 13:07:19,118 - INFO [main:QuorumPeer@834] - tickTime set to 2000
> 2011-10-14 13:07:19,119 - INFO [main:QuorumPeer@845] - minSessionTimeout set
> to -1
> 2011-10-14 13:07:19,119 - INFO [main:QuorumPeer@856] - maxSessionTimeout set
> to -1
> {noformat}
> *Suggestion*
> Move the defaulting logic to the QuorumPeerConfig instead of doing in the
> QuorumPeer
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
