[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131859#comment-13131859
 ] 

Patrick Hunt commented on ZOOKEEPER-1237:
-----------------------------------------

sendBuffer is eating (log then ignore) any Exception generated by sock.write - 
this is problematic.

In this case - cancelledkeyexception, say the caller is watch notification. 
We'll end up flooding the logs with ERRORS, one for each failed notification. 
If we provided indication of failure back to the caller it could decide to stop 
sending notifications earlier.

                
> ERRORs being logged when queued responses are sent after socket has closed.
> ---------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1237
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1237
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.3.4, 3.4.0, 3.5.0
>            Reporter: Patrick Hunt
>             Fix For: 3.3.4, 3.4.0, 3.5.0
>
>
> After applying ZOOKEEPER-1049 to 3.3.3 (I believe the same problem exists in 
> 3.4/3.5 but haven't tested this) I'm seeing the following exception more 
> frequently:
> {noformat}
> Oct 19, 1:31:53 PM ERROR
> Unexpected Exception:
> java.nio.channels.CancelledKeyException
> at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55)
> at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:59)
> at 
> org.apache.zookeeper.server.NIOServerCnxn.sendBuffer(NIOServerCnxn.java:418)
> at 
> org.apache.zookeeper.server.NIOServerCnxn.sendResponse(NIOServerCnxn.java:1509)
> at 
> org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:367)
> at 
> org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:73)
> {noformat}
> This is a long standing problem where we try to send a response after the 
> socket has been closed. Prior to ZOOKEEPER-1049 this issues happened much 
> less frequently (2 sec linger), but I believe it was possible. The timing 
> window is just wider now.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to