[
https://issues.apache.org/jira/browse/ZOOKEEPER-1247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134966#comment-13134966
]
Hadoop QA commented on ZOOKEEPER-1247:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12500656/ZOOKEEPER-1247.patch
against trunk revision 1188523.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/660//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/660//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/660//console
This message is automatically generated.
> dead code in PrepRequestProcessor.pRequest multi case
> -----------------------------------------------------
>
> Key: ZOOKEEPER-1247
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1247
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Attachments: ZOOKEEPER-1247.patch
>
>
> There's an if statement in the for loop which sets the request.hdr.type and
> request.txn in case that an error happened in the preceding multiop. However
> hdr and txn are overwritten anyways at the end of the multi case. The values
> set are only used a bit later to serialize them. This could better be
> achieved with local variables holding the temporary hdr and txn.
> Also the if condition (ke == null) in the catch block is pointless, since the
> surrounding if(ke != null) makes sure that the catch block could only ever be
> reached in a loop where ke == null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
