[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137693#comment-13137693
 ] 

Hadoop QA commented on ZOOKEEPER-1217:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12500638/ZOOKEEPER-1217.patch
  against trunk revision 1190073.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/708//console

This message is automatically generated.
                
> Remove unnecessary MissingSessionException in ZooKeeperServer
> -------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1217
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1217
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>            Priority: Minor
>         Attachments: ZOOKEEPER-1217.patch, ZOOKEEPER-1217.patch
>
>
> MissingSessionException in only thrown and catched once inside this class and 
> can as well be replaced by a boolean return value.
> While I'm at it: The method throwing this Exception makes more sense to be 
> inlined in the one place from where it is called.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to