[ https://issues.apache.org/jira/browse/ZOOKEEPER-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144310#comment-13144310 ]
Patrick Hunt commented on ZOOKEEPER-1270: ----------------------------------------- I'm not sure that's conclusive though, this is the patch, if I apply it on my local system the test passes, but the logs still contain this ZERO outstanding message: {noformat} diff --git a/src/java/main/org/apache/zookeeper/server/quorum/Leader.java b/src/java/main/org/apache/zookeeper/server/quorum/Leader.java index a44f1ee..a4cc127 100644 --- a/src/java/main/org/apache/zookeeper/server/quorum/Leader.java +++ b/src/java/main/org/apache/zookeeper/server/quorum/Leader.java @@ -475,12 +475,14 @@ public class Leader { } if (outstandingProposals.size() == 0) { + LOG.info("PDH outstandingProposals.size() is ZERO"); if (LOG.isDebugEnabled()) { LOG.debug("outstanding is 0"); } return; } if (lastCommitted >= zxid) { + LOG.info("PDH lastCommitted = " + Long.toHexString(lastCommitted) + " zxid = " + Long.toHexString(zxid)); if (LOG.isDebugEnabled()) { LOG.debug("proposal has already been committed, pzxid:" + lastCommitted {noformat} > testEarlyLeaderAbandonment failing intermittently, quorum formed, no serving. > ----------------------------------------------------------------------------- > > Key: ZOOKEEPER-1270 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1270 > Project: ZooKeeper > Issue Type: Bug > Components: server > Reporter: Patrick Hunt > Priority: Blocker > Fix For: 3.4.0, 3.5.0 > > Attachments: ZOOKEEPER-1270tests.patch, ZOOKEEPER-1270tests2.patch, > testEarlyLeaderAbandonment.txt.gz, testEarlyLeaderAbandonment2.txt.gz, > testEarlyLeaderAbandonment3.txt.gz, testEarlyLeaderAbandonment4.txt.gz > > > Looks pretty serious - quorum is formed but no clients can attach. Will > attach logs momentarily. > This test was introduced in the following commit (all three jira commit at > once): > ZOOKEEPER-335. zookeeper servers should commit the new leader txn to their > logs. > ZOOKEEPER-1081. modify leader/follower code to correctly deal with new leader > ZOOKEEPER-1082. modify leader election to correctly take into account current -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira