[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144530#comment-13144530
 ] 

Alexander Shraer commented on ZOOKEEPER-1270:
---------------------------------------------

Hi Mahadev,

I understand, I'm only speaking up here because the patches overlap. When 
ZK-1194 goes in the changes to Leader and LearnerHandler from ZK-1270 become 
unnecessary.

Actually, now that I looked closer on ZK-1270 I realized that the changes to 
Leader.java and LearnerHandler.java are the only code changes here and the rest 
are tests. So ZK-1270 is subsumed by ZK-1194.

I think it would be best to adopt the code changes from ZK-1194 (changes to 2 
lines of code) and merge the tests in these patches. But this is up to you of 
course.


Alex

                
> testEarlyLeaderAbandonment failing intermittently, quorum formed, no serving.
> -----------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1270
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1270
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>            Reporter: Patrick Hunt
>            Assignee: Flavio Junqueira
>            Priority: Blocker
>             Fix For: 3.4.0, 3.5.0
>
>         Attachments: ZOOKEEPER-1270.patch, ZOOKEEPER-1270.patch, 
> ZOOKEEPER-1270_br34.patch, ZOOKEEPER-1270tests.patch, 
> ZOOKEEPER-1270tests2.patch, testEarlyLeaderAbandonment.txt.gz, 
> testEarlyLeaderAbandonment2.txt.gz, testEarlyLeaderAbandonment3.txt.gz, 
> testEarlyLeaderAbandonment4.txt.gz
>
>
> Looks pretty serious - quorum is formed but no clients can attach. Will 
> attach logs momentarily.
> This test was introduced in the following commit (all three jira commit at 
> once):
> ZOOKEEPER-335. zookeeper servers should commit the new leader txn to their 
> logs.
> ZOOKEEPER-1081. modify leader/follower code to correctly deal with new leader
> ZOOKEEPER-1082. modify leader election to correctly take into account current

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to