2 has been flaky for so long, not sure whether it's worth being a blocker. The AsyncHammerTests never pass for me locally. Not sure if it's a problem or not... I am tempted to go with Mahadev on this and get this 3.4 release out the door. I would be happy to help manage a 3.4.1 release soon thereafter if we find serious issues.
C On Sat, Nov 5, 2011 at 3:01 PM, Flavio Junqueira <f...@yahoo-inc.com> wrote: > If 2) is flakey, we need to fix it, no? > > -Flavio > > On Nov 5, 2011, at 6:14 PM, Patrick Hunt wrote: > >> I ran the 1270-1194 patch continually overnight (trunk) in my ci env, >> after ~25 test runs I saw 4 failures: >> >> 1) #402 - QuorumTest.testFollowersStartAfterLeader >> 2) #407 - org.apache.zookeeper.test.FLETest.testLE >> 3) #410 - org.apache.zookeeper.test.AsyncHammerTest.testHammer >> 4) #415 - org.apache.zookeeper.test.AsyncHammerTest.testHammer >> >> 1) client could not connect to reestablished quorum: giving up after >> 30+ seconds. >> 2) known flakey test >> 3) QP failed to shutdown in 30 seconds: >> QuorumPeer[myid=3]0.0.0.0/0.0.0.0:11224 >> 4) QP failed to shutdown in 30 seconds: >> QuorumPeer[myid=1]0.0.0.0/0.0.0.0:11222 >> >> On the plus side no "testearlyleaderabandon" failures. >> >> On the minus side 3/4 are a bit worrysome. Searching back through all >> my previous failures I don't see this happening. Perhaps these changes >> have shifted some timing? My main concern is that this might be caused >> directly by the patch itself.... >> >> Patrick > > flavio > junqueira > > research scientist > > f...@yahoo-inc.com > direct +34 93-183-8828 > > avinguda diagonal 177, 8th floor, barcelona, 08018, es > phone (408) 349 3300 fax (408) 349 3301 > >
