[
https://issues.apache.org/jira/browse/ZOOKEEPER-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149054#comment-13149054
]
Hadoop QA commented on ZOOKEEPER-1251:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12503488/ZOOKEEPER-1251_with_1208_and_1284.patch
against trunk revision 1201045.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/788//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/788//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/788//console
This message is automatically generated.
> call checkSession at begin of PrepRequestProcessor.pRequest
> -----------------------------------------------------------
>
> Key: ZOOKEEPER-1251
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1251
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Attachments: ZOOKEEPER-1251.patch,
> ZOOKEEPER-1251_with_1208_and_1284.patch,
> update_to_1208_showingreadfailure.patch
>
>
> There are 6 locations that call checkSession. This can be reduced to one
> location and makes it also much clearer in which cases checkSession is called
> or not called.
> Note that in case that now the SessionMoved|Expired error is checked first
> before the check for a Marshalling error. However it shouldn't matter which
> error gets reported.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
