[
https://issues.apache.org/jira/browse/ZOOKEEPER-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159629#comment-13159629
]
Hadoop QA commented on ZOOKEEPER-1309:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12505555/zk-1309-1.patch
against trunk revision 1202557.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/799//console
This message is automatically generated.
> Creating a new ZooKeeper client can leak file handles
> -----------------------------------------------------
>
> Key: ZOOKEEPER-1309
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1309
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
> Affects Versions: 3.3.4
> Reporter: Daniel Lord
> Priority: Critical
> Attachments: zk-1309-1.patch
>
>
> If there is an IOException thrown by the constructor of ClientCnxn then file
> handles are leaked because of the initialization of the Selector which is
> never closed.
> final Selector selector = Selector.open();
> If there is an abnormal exit from the constructor then the Selector is not
> closed and file handles are leaked. You can easily see this by setting the
> hosts string to garbage ("qwerty", "asdf", etc.) and then try to open a new
> ZooKeeper connection. I've observed the same behavior in production when
> there were DNS issues where the host names of the ensemble can no longer be
> resolved and the application servers quickly run out of handles attempting to
> (re)connect to zookeeper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
