[
https://issues.apache.org/jira/browse/ZOOKEEPER-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160231#comment-13160231
]
Hadoop QA commented on ZOOKEEPER-1311:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12505642/ZOOKEEPER-1311.diff
against trunk revision 1202557.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/800//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/800//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/800//console
This message is automatically generated.
> Zookeeper test jar is broken
> ----------------------------
>
> Key: ZOOKEEPER-1311
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1311
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Ivan Kelly
> Priority: Blocker
> Fix For: 3.5.0, 3.4.1
>
> Attachments: ZOOKEEPER-1311.diff
>
>
> In http://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.0/ the
> test jar cannot be accessed by maven.
> There are two possible solutions to this.
> a) rename zookeeper-3.4.0-test.jar to zookeeper-3.4.0-tests.jar and remove
> zookeeper-3.4.0-test.pom*
> With this, the maven can access the test jar with
> {code}
> <dependency>
> <groupId>org.apache.zookeeper</groupId>
> <artifactId>zookeeper</artifactId>
> <version>3.4.0</version>
> <type>test-jar</type>
> <scope>test</scope>
> </dependency>
> {code}
> b) Alternatively, zookeeper test could be it's own submodule. To do this, it
> must be deployed in the following layout
> {code}
> ./org/apache/zookeeper/zookeeper-test/3.4.0-BK-SNAPSHOT/zookeeper-test-3.4.0.jar
> ./org/apache/zookeeper/zookeeper-test/3.4.0-BK-SNAPSHOT/zookeeper-test-3.4.0.jar.md5
> ./org/apache/zookeeper/zookeeper-test/3.4.0-BK-SNAPSHOT/zookeeper-test-3.4.0.jar.sha1
> ./org/apache/zookeeper/zookeeper-test/3.4.0-BK-SNAPSHOT/zookeeper-test-3.4.0.pom
> ./org/apache/zookeeper/zookeeper-test/3.4.0-BK-SNAPSHOT/zookeeper-test-3.4.0.pom.md5
> ./org/apache/zookeeper/zookeeper-test/3.4.0-BK-SNAPSHOT/zookeeper-test-3.4.0.pom.sha1
> {code}
> This can then be accessed by maven with
> {code}
> <dependency>
> <groupId>org.apache.zookeeper</groupId>
> <artifactId>zookeeper-test</artifactId>
> <version>3.4.0</version>
> <scope>test</scope>
> </dependency>
> {code}
> I think a) is the better solution.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
