[
https://issues.apache.org/jira/browse/ZOOKEEPER-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170145#comment-13170145
]
Hudson commented on ZOOKEEPER-756:
----------------------------------
Integrated in ZooKeeper-trunk #1397 (See
[https://builds.apache.org/job/ZooKeeper-trunk/1397/])
ZOOKEEPER-756. some cleanup and improvements for zooinspector (Colin
Goodheart-Smithe & Thomas Koch via phunt)
phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214571
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/contrib/zooinspector/NOTICE.txt
* /zookeeper/trunk/src/contrib/zooinspector/TODO
* /zookeeper/trunk/src/contrib/zooinspector/build.xml
* /zookeeper/trunk/src/contrib/zooinspector/config/defaultConnectionSettings.cfg
* /zookeeper/trunk/src/contrib/zooinspector/config/defaultNodeVeiwers.cfg
* /zookeeper/trunk/src/contrib/zooinspector/config/defaultNodeViewers.cfg
* /zookeeper/trunk/src/contrib/zooinspector/icons
* /zookeeper/trunk/src/contrib/zooinspector/lib/jtoaster-1.0.4.jar
* /zookeeper/trunk/src/contrib/zooinspector/lib/log4j.properties
* /zookeeper/trunk/src/contrib/zooinspector/licences/epl-v10.html
* /zookeeper/trunk/src/contrib/zooinspector/src/java/com
* /zookeeper/trunk/src/contrib/zooinspector/src/java/com/nitido
* /zookeeper/trunk/src/contrib/zooinspector/src/java/com/nitido/utils
* /zookeeper/trunk/src/contrib/zooinspector/src/java/com/nitido/utils/toaster
*
/zookeeper/trunk/src/contrib/zooinspector/src/java/com/nitido/utils/toaster/Toaster.java
*
/zookeeper/trunk/src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/ZooInspector.java
*
/zookeeper/trunk/src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/IconResource.java
*
/zookeeper/trunk/src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/Toolbar.java
*
/zookeeper/trunk/src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/ZooInspectorAboutDialog.java
*
/zookeeper/trunk/src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/ZooInspectorIconResources.java
*
/zookeeper/trunk/src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/ZooInspectorNodeViewersDialog.java
*
/zookeeper/trunk/src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/ZooInspectorPanel.java
*
/zookeeper/trunk/src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/ZooInspectorTreeViewer.java
*
/zookeeper/trunk/src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/nodeviewer/NodeViewerData.java
* /zookeeper/trunk/src/contrib/zooinspector/src/main
* /zookeeper/trunk/src/contrib/zooinspector/src/main/resources
* /zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons
* /zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango
* /zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/16x16
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/add.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/document-new.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/document-save.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/down.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/media-playback-start.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/media-playback-stop.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/remove.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/up.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/view-refresh.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/mimetypes
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/mimetypes/text-x-generic.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/places
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/places/folder.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/places/user-trash.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/status
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/status/info.png
* /zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/22x22
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/add.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/document-new.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/document-save.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/down.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/media-playback-start.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/media-playback-stop.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/remove.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/up.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/view-refresh.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/mimetypes
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/mimetypes/text-x-generic.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/places
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/places/folder.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/places/user-trash.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/status
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/status/info.png
* /zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/24x24
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/add.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/document-new.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/document-save.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/down.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/media-playback-start.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/media-playback-stop.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/remove.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/up.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/view-refresh.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/mimetypes
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/mimetypes/text-x-generic.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/places
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/places/folder.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/places/user-trash.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/status
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/status/info.png
* /zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/32x32
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/add.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/document-new.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/document-save.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/down.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/media-playback-start.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/media-playback-stop.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/remove.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/up.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/view-refresh.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/mimetypes
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/mimetypes/text-x-generic.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/places
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/places/folder.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/places/user-trash.png
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/status
*
/zookeeper/trunk/src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/status/info.png
* /zookeeper/trunk/src/contrib/zooinspector/zooInspector-dev.sh
* /zookeeper/trunk/src/contrib/zooinspector/zooInspector.cmd
* /zookeeper/trunk/src/contrib/zooinspector/zooInspector.sh
> some cleanup and improvements for zooinspector
> ----------------------------------------------
>
> Key: ZOOKEEPER-756
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-756
> Project: ZooKeeper
> Issue Type: Improvement
> Components: contrib
> Affects Versions: 3.3.0
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Labels: zooinspector
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-756.patch, ZOOKEEPER-756.patch,
> ZOOKEEPER-756.patch, ZOOKEEPER-756.patch, ZOOKEEPER-756.patch,
> Zooinspector-patch.patch, icons.tar.gz, zooInspectorChanges.patch,
> zooInspectorChanges.patch
>
>
> Copied from the already closed ZOOKEEPER-678:
> * specify the exact URL, where the icons are from. It's best to include the
> link also in the NOTICE.txt file.
> It seems, that zooinspector finds it's icons only if the icons folder is in
> the current path. But when I install zooinspector as part of the Zookeeper
> Debian package, I want to be able to call it regardless of the current path.
> Could you use getRessources or something so that I can point to the icons
> location from the wrapper shell script?
> Can I place the zooinspector config files in /etc/zookeeper/zooinspector/ ?
> Could I give zooinspector a property to point to the config file location?
> There are several places, where viewers is missspelled as "Veiwers". Please
> do a case insensitive search for "veiw" to correct these. Even the config
> file "defaultNodeVeiwers.cfg" is missspelled like this. This has the
> potential to confuse the hell out of people when debugging something!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
