[
https://issues.apache.org/jira/browse/ZOOKEEPER-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-1333:
------------------------------------
Attachment: ZOOKEEPER-1333.patch
this patch fixes the problem as outlined in the comments.
However I just noticed that the tests still pass when the "throw
NoNodeException" is commented out. So this leads me to believe we are not
testing this code path.
I'm continuing to work on this - specifically added tests for this code path.
Ben if you had an idea re the logging lmk what it should say.
> NPE in FileTxnSnapLog when restarting a cluster
> -----------------------------------------------
>
> Key: ZOOKEEPER-1333
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1333
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.0
> Reporter: Andrew McNair
> Assignee: Patrick Hunt
> Priority: Blocker
> Fix For: 3.4.2
>
> Attachments: ZOOKEEPER-1333.patch, ZOOKEEPER-1333.patch,
> test_case.diff, test_case.diff
>
>
> I think a NPE was created in the fix for
> https://issues.apache.org/jira/browse/ZOOKEEPER-1269
> Looking in DataTree.processTxn(TxnHeader header, Record txn) it seems likely
> that if rc.err != Code.OK then rc.path will be null.
> I'm currently working on a minimal test case for the bug, I'll attach it to
> this issue when it's ready.
> java.lang.NullPointerException
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.processTransaction(FileTxnSnapLog.java:203)
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:150)
> at
> org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:223)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:418)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:410)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:151)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:111)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:78)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
