[
https://issues.apache.org/jira/browse/ZOOKEEPER-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175170#comment-13175170
]
jirapos...@reviews.apache.org commented on ZOOKEEPER-1296:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3116/#review4092
-----------------------------------------------------------
http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml
<https://reviews.apache.org/r/3116/#comment9199>
I had an idea when reviewing another jira recently. That fits with this and
the new pkging really well. (sorry, that was after I mentioned about adding to
the admin guide).
I now think we should add man pages for executables such as scripts. I
think having a reference from the guide is not nearly as useful. Also, now that
we have the pkgs we can include the man pages there. It's a much better
solution than the guide for stuff like this.
Would you mind moving this into a man page? Seems like mainly reformatting.
http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml
<https://reviews.apache.org/r/3116/#comment9200>
"a configuration file..."
http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml
<https://reviews.apache.org/r/3116/#comment9201>
should we give the example with sudo? or just user level.
http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml
<https://reviews.apache.org/r/3116/#comment9202>
I'm not sure what this means "Forward to start ..."
?
http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh
<https://reviews.apache.org/r/3116/#comment9203>
should this be required given having separate dirs is optional?
http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh
<https://reviews.apache.org/r/3116/#comment9207>
are the values after the = supposed to be defaults? because --hosts has a
default of host1,host2, that' doesn't seem right.
http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh
<https://reviews.apache.org/r/3116/#comment9204>
running twice would overwrite the original, is there any way to store
multiple versions?
http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh
<https://reviews.apache.org/r/3116/#comment9206>
does this mean the datadir must exist prior to running the script? (would
be good to document)
http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh
<https://reviews.apache.org/r/3116/#comment9205>
shouldn't we allow the quorum and election ports to be specified?
http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh
<https://reviews.apache.org/r/3116/#comment9208>
this is wrong. we don't want to have autopurge on by default. it's too new
of a feature.
http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh
<https://reviews.apache.org/r/3116/#comment9209>
same q here re backup.
http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh
<https://reviews.apache.org/r/3116/#comment9210>
I'm not sure I get this, what's the expectation, that the user will run
this on each of the servers, with exactly the same parameters? I see that the
myid is based on this assumption, that seems like it's going to cause alot of
problems. With zkconf I generated all the environments (for all servers) then
allow the user to copy them to the right place. That limits this type of issue.
- Patrick
On 2011-12-09 20:45:09, Eric Yang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3116/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-09 20:45:09)
bq.
bq.
bq. Review request for zookeeper, Patrick Hunt and Mahadev Konar.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Add a setup script for ZooKeeper
bq.
bq.
bq. This addresses bug ZOOKEEPER-1296.
bq. https://issues.apache.org/jira/browse/ZOOKEEPER-1296
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/zookeeper/trunk/build.xml 1200013
bq.
http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml
1200013
bq.
http://svn.apache.org/repos/asf/zookeeper/trunk/src/packages/zookeeper-setup-conf.sh
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3116/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Eric
bq.
bq.
> Add zookeeper-setup-conf.sh script
> ----------------------------------
>
> Key: ZOOKEEPER-1296
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1296
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 3.4.0
> Environment: Shell script
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1296-1.patch, ZOOKEEPER-1296-2.patch,
> ZOOKEEPER-1296.patch
>
>
> It would be nice to provide a setup script for zoo.cfg and zookeeper-env.sh.
> The proposed script will provide the following options:
> {noformat}
> usage: /usr/sbin/zookeeper-setup-conf.sh <parameters>
> Required parameters:
> --conf-dir Set ZooKeeper configuration directory
> --log-dir Set ZooKeeper log directory
> Optional parameters:
> --auto-purge-interval=1 Set snapshot auto purge interval
> --client-port=2181 Set client port
> --data-dir=/var/lib/zookeeper Set data directory
> --hosts=host1,host2 Set ZooKeeper qourum hostnames
> --init-limit=10 Set initial sync limit
> --java-home Set JAVA_HOME location
> --snapshot-count=3 Set snapshot retain count
> --sync-limit=5 Set sync limit
> --tick-time=2000 Set milliseconds of each tick
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
