[
https://issues.apache.org/jira/browse/ZOOKEEPER-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175739#comment-13175739
]
Alexander Shraer commented on ZOOKEEPER-1343:
---------------------------------------------
yeah, but when the leader invokes getEpochToPropose it passes
self.getAcceptedEpoch() and you're invoking setAcceptingEpoch(5) in the test
before starting the leader thread. So it should be invoked twice with 5.
> getEpochToPropose should check if lastAcceptedEpoch is greater or equal than
> epoch
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1343
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1343
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1343.patch
>
>
> The following block in Leader.getEpochToPropose:
> {noformat}
> if (lastAcceptedEpoch > epoch) {
> epoch = lastAcceptedEpoch+1;
> }
> {noformat}
> needs to be fixed, since it doesn't increment the epoch variable in the case
> epoch != -1 (initial value) and lastAcceptedEpoch is equal. The fix trivial
> and corresponds to changing > with >=.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
