[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176099#comment-13176099
 ] 

Hadoop QA commented on ZOOKEEPER-1326:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12508663/ZOOKEEPER-1326.patch
  against trunk revision 1222816.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/858//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/858//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/858//console

This message is automatically generated.
                
> The CLI commands "delete" and "rmr" are confusing. Can we have "rm" + "rmr" 
> instead?
> ------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1326
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1326
>             Project: ZooKeeper
>          Issue Type: Wish
>          Components: java client
>    Affects Versions: 3.4.0
>            Reporter: Harsh J
>            Priority: Trivial
>         Attachments: ZOOKEEPER-1326.patch, ZOOKEEPER-1326.patch
>
>
> ZOOKEEPER-729 introduced 'rmr' for recursive 'delete' operations on a given 
> node. Going by the unix convention, wouldn't it be much better if we were to 
> have an 'rm' if there was an 'rmr' added?
> The current set is confusing. Or should we have 'delete' and 'deleteall' or 
> summat?
> I know this is a nitpick, but I just dislike to see bad keywords used for 
> commands.
> I'm OK to produce a backwards-compatible patch if this is acceptable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to