[
https://issues.apache.org/jira/browse/ZOOKEEPER-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181043#comment-13181043
]
Hadoop QA commented on ZOOKEEPER-1328:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12507172/ZOOKEEPER-1328.patch
against trunk revision 1227927.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/881//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/881//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/881//console
This message is automatically generated.
> Misplaced assertion for the test case 'FLELostMessageTest' and not
> identifying misfunctions
> -------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1328
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1328
> Project: ZooKeeper
> Issue Type: Test
> Components: leaderElection
> Affects Versions: 3.4.0
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1328.patch
>
>
> Assertion for testLostMessage is kept inside the thread.run() method. Due to
> this the assertion failure will not be reflected in the main testcase.
> I have observed the test case is still passing in case of the assert failure
> or misfunction. Instead, the assertion can be moved to the test case -
> testLostMessage.
> {noformat}
> class LEThread extends Thread {
> public void run(){
> peer.setCurrentVote(v);
> LOG.info("Finished election: " + i + ", " + v.getId());
> Assert.assertTrue("State is not leading.",
> peer.getPeerState() == ServerState.LEADING);
> }
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
