-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3410/
-----------------------------------------------------------
(Updated 2012-01-06 05:02:48.623412)
Review request for zookeeper.
Summary
-------
LearnerZooKeeperServer has no option to disable JMX registrations. Curator has
a test ZK server cluster. Due to the intricacies of JMX, the registrations
cannot be easily undone. In order for the Curator Test cluster to be re-usable
in a testing session, JavaAssist ugliness was necessary to make
LearnerZooKeeperServer.registerJMX() and LearnerZooKeeperServer.unregisterJMX()
NOPs.
This addresses bug ZOOKEEPER-1350.
https://issues.apache.org/jira/browse/ZOOKEEPER-1350
Diffs (updated)
-----
/src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java 1227917
/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1227917
/src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java
1227917
/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
1227917
/src/java/main/org/apache/zookeeper/server/quorum/LeaderElection.java 1227917
/src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java
1227917
/src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java
1227917
/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1227917
/src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java
1227917
/src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 1227917
Diff: https://reviews.apache.org/r/3410/diff
Testing
-------
Thanks,
Jordan
